Jimexist commented on code in PR #3102:
URL: https://github.com/apache/arrow-rs/pull/3102#discussion_r1023389113
##########
parquet/src/file/reader.rs:
##########
@@ -143,6 +145,10 @@ pub trait RowGroupReader: Send + Sync {
Ok(col_reader)
}
+ #[cfg(feature = "bloom")]
Review Comment:
@tustvold are you suggesting dropping the feature gate altogether and enable
it by default? I added the feature gate trying to reduce binary size but then
if the feature is very likely to be used there's no need for this gate any more.
##########
parquet/src/file/reader.rs:
##########
@@ -143,6 +145,10 @@ pub trait RowGroupReader: Send + Sync {
Ok(col_reader)
}
+ #[cfg(feature = "bloom")]
Review Comment:
@tustvold are you also suggesting dropping the feature gate altogether and
enable it by default? I added the feature gate trying to reduce binary size but
then if the feature is very likely to be used there's no need for this gate any
more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
