Jimexist commented on code in PR #3102:
URL: https://github.com/apache/arrow-rs/pull/3102#discussion_r1023393988
##########
parquet/src/file/reader.rs:
##########
@@ -143,6 +145,10 @@ pub trait RowGroupReader: Send + Sync {
Ok(col_reader)
}
+ #[cfg(feature = "bloom")]
Review Comment:
also thanks for the suggestion, I agree with this direction, however I have:
- #3119
coming up, so I'd like to maybe merge this as is and quickly follow up on
this after it is merged. do you think that works?
##########
parquet/src/file/reader.rs:
##########
@@ -143,6 +145,10 @@ pub trait RowGroupReader: Send + Sync {
Ok(col_reader)
}
+ #[cfg(feature = "bloom")]
Review Comment:
also thanks for the suggestion, I agree with this direction, however I have:
- #3119
coming up, so I'd like to maybe merge this as is and quickly follow up on
this after it is merged. do you think that works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
