mingmwang commented on code in PR #4219:
URL: https://github.com/apache/arrow-datafusion/pull/4219#discussion_r1023841101


##########
datafusion/core/src/physical_plan/planner.rs:
##########
@@ -932,15 +933,41 @@ impl DefaultPhysicalPlanner {
 
                     if session_state.config.target_partitions > 1
                         && session_state.config.repartition_joins
+                        && !session_state.config.prefer_hash_join
                     {
-                        // Use hash partition by default to parallelize hash 
joins
+                        // Use SortMergeJoin if hash join is not preferred
+                        // Sort-Merge join support currently is experimental
+                        if join_filter.is_some() {
+                            // TODO SortMergeJoinExec need to support join 
filter
+                            Err(DataFusionError::Plan("SortMergeJoinExec does 
not support join_filter now.".to_string()))

Review Comment:
   Sure, will do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to