askoa commented on code in PR #3109:
URL: https://github.com/apache/arrow-rs/pull/3109#discussion_r1025941001
##########
object_store/src/azure/client.rs:
##########
@@ -148,13 +152,20 @@ pub(crate) struct AzureClient {
impl AzureClient {
/// create a new instance of [AzureClient]
- pub fn new(config: AzureConfig) -> Self {
- let client = reqwest::ClientBuilder::new()
- .https_only(!config.allow_http)
- .build()
- .unwrap();
+ pub fn new(config: AzureConfig) -> Result<Self> {
+ let builder = ReqwestClient::builder();
+
+ let client = if let Some(url) = config.proxy_url.as_ref() {
Review Comment:
Same as my previous comment on AWS builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
