askoa commented on code in PR #3109:
URL: https://github.com/apache/arrow-rs/pull/3109#discussion_r1025942341
##########
object_store/src/gcp/mod.rs:
##########
@@ -790,19 +801,38 @@ impl GoogleCloudStorageBuilder {
service_account_path,
client,
retry_config,
+ proxy_url,
} = self;
let bucket_name = bucket_name.ok_or(Error::MissingBucketName {})?;
let service_account_path =
service_account_path.ok_or(Error::MissingServiceAccountPath)?;
- let client = client.unwrap_or_else(Client::new);
+ let client = if let Some(url) = proxy_url {
Review Comment:
the better coding pattern is
```
let client = match proxy_url, client {
Some(url), Some(client) => {}
Some(url), None => {}
None, _ =>
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
