tustvold commented on code in PR #3119:
URL: https://github.com/apache/arrow-rs/pull/3119#discussion_r1029224288
##########
parquet/src/column/writer/mod.rs:
##########
@@ -231,6 +238,19 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a, E>
{
// Used for level information
encodings.insert(Encoding::RLE);
+ let bloom_filter_enabled = props.bloom_filter_enabled(descr.path());
+ let bloom_filter = if bloom_filter_enabled {
+ if let Some(ndv) = props.bloom_filter_ndv(descr.path()) {
+ let fpp = props.bloom_filter_fpp(descr.path());
+ Some(Sbbf::new_with_ndv_fpp(ndv, fpp))
+ } else {
Review Comment:
I think it is perhaps a little surprising that `bloom_filter_max_bytes` is
ignored if `ndv` is set
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
