tustvold commented on code in PR #3119:
URL: https://github.com/apache/arrow-rs/pull/3119#discussion_r1029226696
##########
parquet/src/file/properties.rs:
##########
@@ -515,27 +595,24 @@ impl Default for EnabledStatistics {
///
/// If a field is `None`, it means that no specific value has been set for
this column,
/// so some subsequent or default value must be used.
-#[derive(Debug, Clone, PartialEq)]
+#[derive(Debug, Clone, Default, PartialEq)]
struct ColumnProperties {
encoding: Option<Encoding>,
codec: Option<Compression>,
dictionary_enabled: Option<bool>,
statistics_enabled: Option<EnabledStatistics>,
max_statistics_size: Option<usize>,
+ /// bloom filter enabled
+ bloom_filter_enabled: Option<bool>,
+ /// bloom filter expected number of distinct values
+ bloom_filter_ndv: Option<u64>,
+ /// bloom filter false positive probability
+ bloom_filter_fpp: Option<f64>,
+ /// bloom filter max number of bytes
+ bloom_filter_max_bytes: Option<u32>,
Review Comment:
I wonder if it would be simpler to just ask users to specify the bloom
filter size, and provide a free function to compute the size based on ndv and
fpp?
The interaction of these three properties isn't immediately apparent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
