lidavidm commented on code in PR #14698:
URL: https://github.com/apache/arrow/pull/14698#discussion_r1029478889


##########
python/pyarrow/_flight.pyx:
##########
@@ -1548,6 +1548,9 @@ cdef class FlightClient(_Weakrefable):
         writer : FlightStreamWriter
         reader : FlightMetadataReader
         """
+        if schema is None:

Review Comment:
   Also, in general I question if `pyarrow_unwrap_schema` et al should accept 
None by default, it seems such errors would be caught if they raised and 
translating None to nullptr had to be opt in



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to