lidavidm commented on code in PR #14698:
URL: https://github.com/apache/arrow/pull/14698#discussion_r1029906948
##########
cpp/src/arrow/ipc/writer.cc:
##########
@@ -1377,6 +1377,10 @@ namespace internal {
Result<std::unique_ptr<RecordBatchWriter>> OpenRecordBatchWriter(
std::unique_ptr<IpcPayloadWriter> sink, const std::shared_ptr<Schema>&
schema,
const IpcWriteOptions& options) {
+ // constructor for IpcFormatWriter here dereferences ptr to schema.
+ if (schema == nullptr) {
+ return Status::Invalid("nullptr for Schema not allowed.");
Review Comment:
nit: no need for a period here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
