isidentical commented on PR #4219: URL: https://github.com/apache/arrow-datafusion/pull/4219#issuecomment-1325518946
I wasn't able to go through the last revision in detail but overall this looks great 💯 A minor question of mine is still standing though (maybe let's do a follow up ticket on it): https://github.com/apache/arrow-datafusion/pull/4219#discussion_r1023219190 (`collection_size_threshold` represents the size in both the number of rows and the number of bytes, which is a bit confusing because the distinction is only internal when one form of statistics is not available) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
