mingmwang commented on code in PR #4219:
URL: https://github.com/apache/arrow-datafusion/pull/4219#discussion_r1029130930
##########
datafusion/core/src/physical_plan/joins/mod.rs:
##########
@@ -29,6 +29,9 @@ pub enum PartitionMode {
Partitioned,
/// Left side will collected into one partition
CollectLeft,
+ /// When set to Auto, DataFusion optimizer will decide which PartitionMode
mode(Partitioned/CollectLeft) is optimal based on statistics.
+ /// It will also consider swapping the left and right inputs for the Join
Review Comment:
You are right. Especially when the mode is CollectLeft, some join types is
unable to run CollectLeft mode.
https://github.com/apache/arrow-datafusion/blob/d5d2de3362649db85ad54161ee28d9374ed3437c/datafusion/core/src/physical_optimizer/join_selection.rs#L284-L286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
