jackwener commented on code in PR #4333:
URL: https://github.com/apache/arrow-datafusion/pull/4333#discussion_r1032788324
##########
datafusion/core/src/datasource/view.rs:
##########
@@ -474,7 +474,8 @@ mod tests {
let formatted = arrow::util::pretty::pretty_format_batches(&plan)
.unwrap()
.to_string();
- assert!(formatted.contains("ParquetExec: limit=Some(10)"));
+ // TODO: limit_push_down support SubqueryAlias
Review Comment:
Add a new issue to trace #4381.
Yes, I'll follow up on this soon, the reason I didn't do this in this PR is
because I didn't want to mix too many features into one big PR (Not only
pushdown limit, other rules also need to support it, I want to support them
altogether, and add ut for it, it will be easy to review.).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
