jackwener commented on code in PR #4333: URL: https://github.com/apache/arrow-datafusion/pull/4333#discussion_r1032793752
########## datafusion/core/tests/sql/window.rs: ########## @@ -335,18 +335,19 @@ async fn window_expr_eliminate() -> Result<()> { " Sort: d.b ASC NULLS LAST [b:Utf8, max_a:Int64;N]", " Projection: d.b, MAX(d.a) AS max_a [b:Utf8, max_a:Int64;N]", " Aggregate: groupBy=[[d.b]], aggr=[[MAX(d.a)]] [b:Utf8, MAX(d.a):Int64;N]", - " Projection: _data2.a, _data2.b, alias=d [a:Int64, b:Utf8]", - " Projection: s.a, s.b, alias=_data2 [a:Int64, b:Utf8]", - " Projection: a, b, alias=s [a:Int64, b:Utf8]", - " Union [a:Int64, b:Utf8]", - " Projection: Int64(1) AS a, Utf8(\"aa\") AS b [a:Int64, b:Utf8]", - " EmptyRelation []", - " Projection: Int64(3) AS a, Utf8(\"aa\") AS b [a:Int64, b:Utf8]", - " EmptyRelation []", - " Projection: Int64(5) AS a, Utf8(\"bb\") AS b [a:Int64, b:Utf8]", - " EmptyRelation []", - " Projection: Int64(7) AS a, Utf8(\"bb\") AS b [a:Int64, b:Utf8]", - " EmptyRelation []", + " SubqueryAlias: d [a:Int64, b:Utf8]", + " SubqueryAlias: _data2 [a:Int64, b:Utf8]", Review Comment: Future ticket #4383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org