wjones127 commented on code in PR #14679: URL: https://github.com/apache/arrow/pull/14679#discussion_r1033836090
########## r/R/csv.R: ########## @@ -418,6 +418,8 @@ CsvTableReader$create <- function(file, #' The `CsvWriteOptions$create()` factory method takes the following arguments: #' - `include_header` Whether to write an initial header line with column names #' - `batch_size` Maximum number of rows processed at a time. Default is 1024. +#' - `null_string` The string to be written for null values. Must not contain +#' quotation marks. Default is `NA`. Review Comment: Perhaps our goal should be to support the `readr` options, but not necessarily to match the `readr` defaults. Does that seem like a reasonable policy? Right now the function takes `readr` arguments as a convenience, and also has Arrow-specific parameter that may overlap. It seems like if we wanted an API that matched the defaults, we should have a separate API that exclusively took `readr` options. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
