wjones127 commented on code in PR #14679:
URL: https://github.com/apache/arrow/pull/14679#discussion_r1036313020
##########
r/R/csv.R:
##########
@@ -722,9 +731,10 @@ write_csv_arrow <- function(x,
if (is.null(write_options)) {
write_options <- readr_to_csv_write_options(
- include_header = include_header,
- batch_size = batch_size
+ col_names = include_header,
+ na = na
)
+ # TODO: what to do with batch_size??
Review Comment:
I could do that. This PR might be a little big though :)
##########
r/R/csv.R:
##########
@@ -722,9 +731,10 @@ write_csv_arrow <- function(x,
if (is.null(write_options)) {
write_options <- readr_to_csv_write_options(
- include_header = include_header,
- batch_size = batch_size
+ col_names = include_header,
+ na = na
)
+ # TODO: what to do with batch_size??
Review Comment:
I will do that. This PR might be a little big though :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
