fatemehp commented on code in PR #14603:
URL: https://github.com/apache/arrow/pull/14603#discussion_r1035206919
##########
cpp/src/parquet/column_reader.h:
##########
@@ -115,11 +116,26 @@ class PARQUET_EXPORT PageReader {
bool always_compressed = false,
const CryptoContext* ctx = NULLPTR);
+ // If skip_page_callback_ is set, NextPage() must use this callback to
determine if it
Review Comment:
Done
##########
cpp/src/parquet/column_reader.h:
##########
@@ -115,11 +116,26 @@ class PARQUET_EXPORT PageReader {
bool always_compressed = false,
const CryptoContext* ctx = NULLPTR);
+ // If skip_page_callback_ is set, NextPage() must use this callback to
determine if it
+ // should return or skip and move to the next page. If the callback function
returns
Review Comment:
Done
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -386,6 +386,57 @@ std::shared_ptr<Page> SerializedPageReader::NextPage() {
throw ParquetException("Invalid page header");
}
+ // Do some checks before trying to decrypt and/or decompress the page.
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
