fatemehp commented on code in PR #14603:
URL: https://github.com/apache/arrow/pull/14603#discussion_r1035378763
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -263,6 +269,11 @@ class SerializedPageReader : public PageReader {
int compressed_len, int
uncompressed_len,
int levels_byte_len = 0);
+ // Returns true for non-data pages, and if we should skip based on
+ // skip_page_callback_. Performs basic checks on values in the page header.
+ // Fills in page_statistics.
+ bool ShouldSkipPage(EncodedStatistics& page_statistics);
Review Comment:
Done
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -486,9 +525,8 @@ std::shared_ptr<Page> SerializedPageReader::NextPage() {
header.repetition_levels_byte_length, uncompressed_len,
is_compressed,
page_statistics);
} else {
- // We don't know what this page type is. We're allowed to skip non-data
- // pages.
- continue;
+ // We have already skipped non-data pages in ShouldSkipPage().
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
