aarashy commented on issue #3215:
URL: https://github.com/apache/arrow-rs/issues/3215#issuecomment-1332567160

   @viirya , thanks for your helpful reply. I've created this issue in the 
arrow repo to track it there. (https://github.com/apache/arrow/issues/14791)
   
   Now my last question is, are we okay with the fact that the 
`UnalignedBitChunk` indexes into the slice without checking the bounds first, 
causing a panic? 
   
   It seems like, in situations where the input arrow bytes are the correct 
shape but have some subtle bug like this, `arrow-rs` is vulnerable to panic. Do 
you think it's important to add appropriate checks here instead of using 
functions like `new_unchecked`? By its name, this function seems to believe 
that essential invariants like buffer size have already been verified, but in 
this case they are not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to