tustvold commented on issue #3215: URL: https://github.com/apache/arrow-rs/issues/3215#issuecomment-1332571043
> Now my last question is, are we okay with the fact that the UnalignedBitChunk indexes into the slice without checking the bounds first, causing a panic? I think the issue here is that currently `create_dictionary_array` isn't performing validation. I think this is incorrect and should be fixed. `UnalignedBitChunk` expects that its inputs are already bounds checked, and panics as an invariant has been violated. This I think is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
