alamb commented on code in PR #4340:
URL: https://github.com/apache/arrow-datafusion/pull/4340#discussion_r1036372866
##########
datafusion/core/src/physical_plan/file_format/parquet/page_filter.rs:
##########
@@ -123,7 +122,7 @@ pub(crate) fn build_page_filter(
if let (Some(file_offset_indexes), Some(file_page_indexes)) =
(file_offset_indexes, file_page_indexes)
{
- let mut row_selections =
VecDeque::with_capacity(page_index_predicates.len());
+ let mut row_selections =
Vec::with_capacity(page_index_predicates.len());
Review Comment:
since `row_selections` are always appended to (never pop_front, for example)
I think Vec is just fine and using VecDequeue just makes the code more confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
