alamb commented on code in PR #4340:
URL: https://github.com/apache/arrow-datafusion/pull/4340#discussion_r1036373826
##########
datafusion/core/src/physical_plan/file_format/parquet/page_filter.rs:
##########
@@ -197,93 +195,14 @@ pub(crate) fn build_page_filter(
///
/// The final selection is the intersection of these `RowSelector`s:
/// * `final_selection:[ Skip(0~199), Read(200~249), Skip(250~299)]`
-fn combine_multi_col_selection(
- row_selections: VecDeque<Vec<RowSelector>>,
-) -> Vec<RowSelector> {
+fn combine_multi_col_selection(row_selections: Vec<Vec<RowSelector>>) ->
RowSelection {
row_selections
.into_iter()
- .reduce(intersect_row_selection)
+ .map(RowSelection::from)
+ .reduce(|s1, s2| s1.intersection(&s2))
.unwrap()
}
-/// combine two `RowSelection` return the intersection
-/// For example:
-/// self: NNYYYYNNY
-/// other: NYNNNNNNY
-///
-/// returned: NNNNNNNNY
-/// set `need_combine` true will combine result: Select(2) + Select(1) +
Skip(2) -> Select(3) + Skip(2)
-///
-/// Move to arrow-rs: https://github.com/apache/arrow-rs/issues/3003
-pub(crate) fn intersect_row_selection(
Review Comment:
upstreamed in https://github.com/apache/arrow-rs/pull/3173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
