jackwener commented on code in PR #4447:
URL: https://github.com/apache/arrow-datafusion/pull/4447#discussion_r1036707613
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -910,11 +922,9 @@ mod tests {
// rewrite to CNF
// (c = 1 OR c = 1) [can pushDown] AND (c = 1 OR b > 3) AND (b > 2 OR
C = 1) AND (b > 2 OR b > 3)
- let expected = "\
- Filter: (test.c = Int64(1) OR b > Int64(3)) AND (b > Int64(2) OR
test.c = Int64(1)) AND (b > Int64(2) OR b > Int64(3))\
+ let expected = "Filter: (test.c = Int64(1) OR test.c = Int64(1)) AND
(test.c = Int64(1) OR b > Int64(3)) AND (b > Int64(2) OR test.c = Int64(1)) AND
(b > Int64(2) OR b > Int64(3))\
\n Aggregate: groupBy=[[test.a]], aggr=[[SUM(test.b) AS b]]\
- \n Filter: test.c = Int64(1) OR test.c = Int64(1)\
- \n TableScan: test";
Review Comment:
Original plan is wrong.😂
I think we need to delete this wrong UT.
Filter include column that not in output of Aggregate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
