Ted-Jiang commented on code in PR #4447:
URL: https://github.com/apache/arrow-datafusion/pull/4447#discussion_r1036727421
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -910,11 +922,9 @@ mod tests {
// rewrite to CNF
// (c = 1 OR c = 1) [can pushDown] AND (c = 1 OR b > 3) AND (b > 2 OR
C = 1) AND (b > 2 OR b > 3)
- let expected = "\
- Filter: (test.c = Int64(1) OR b > Int64(3)) AND (b > Int64(2) OR
test.c = Int64(1)) AND (b > Int64(2) OR b > Int64(3))\
+ let expected = "Filter: (test.c = Int64(1) OR test.c = Int64(1)) AND
(test.c = Int64(1) OR b > Int64(3)) AND (b > Int64(2) OR test.c = Int64(1)) AND
(b > Int64(2) OR b > Int64(3))\
\n Aggregate: groupBy=[[test.a]], aggr=[[SUM(test.b) AS b]]\
- \n Filter: test.c = Int64(1) OR test.c = Int64(1)\
- \n TableScan: test";
Review Comment:
Yes, it was my fault.
`col_c` should not exist in filter. Need delete it 😂
Is this case show you fix: filter with agg result should not push down?
@jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
