pitrou commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r507837493
##########
File path: cpp/src/parquet/arrow/reader_internal.cc
##########
@@ -645,7 +645,9 @@ static Status DecimalIntegerTransfer(RecordReader* reader,
MemoryPool* pool,
template <typename ParquetType>
Status TransferDecimal(RecordReader* reader, MemoryPool* pool,
const std::shared_ptr<DataType>& type, Datum* out) {
- DCHECK_EQ(type->id(), ::arrow::Type::DECIMAL);
+ if (type->id() != ::arrow::Type::DECIMAL128) {
+ return Status::Invalid("Only reading decimal128 types is currently
supported");
Review comment:
`Status::NotImplemented` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
