emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508062401
##########
File path: cpp/src/arrow/type.cc
##########
@@ -131,6 +133,7 @@ std::string ToString(Type::type id) {
TO_STRING_CASE(FLOAT)
TO_STRING_CASE(DOUBLE)
TO_STRING_CASE(DECIMAL)
Review comment:
this one should. We have DECIMAL for backwards compatibility, I think
the remaining places that it is used are places we will need to update to
support Decimal256. By leaving them as DECIMAL we can find them easily with by
commenting out the alias. Does this sound reasonable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
