alamb commented on code in PR #4534:
URL: https://github.com/apache/arrow-datafusion/pull/4534#discussion_r1041483341
##########
datafusion/sql/src/utils.rs:
##########
@@ -535,16 +535,8 @@ pub(crate) fn make_decimal_type(
}
}
-// Normalize an identifier to a lowercase string unless the identifier is
quoted.
-pub(crate) fn normalize_ident(id: &Ident) -> String {
- match id.quote_style {
- Some(_) => id.value.clone(),
Review Comment:
here the value is always cloned which is not necessary for most uses when we
already have an owned string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
