alamb commented on code in PR #4534:
URL: https://github.com/apache/arrow-datafusion/pull/4534#discussion_r1042586702
##########
datafusion/sql/src/planner.rs:
##########
@@ -446,7 +444,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
for cte in with.cte_tables {
// A `WITH` block can't use the same name more than once
- let cte_name = normalize_ident(&cte.alias.name);
+ let cte_name = normalize_ident(cte.alias.name.clone());
Review Comment:
previously normalize_indent *always* cloned. Now it only clones in a few
places and most of the time can reuse the String in the sqlparser-ast directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
