rdettai commented on pull request #8300:
URL: https://github.com/apache/arrow/pull/8300#issuecomment-713467151
I agree that this PR is hanging, but as this is an API change, I guess its
better to think things through before moving forward! 😄 This should maybe have
been thought through in a design document rather than in the PR... 😅
Its true that most of the time you will have the length around from an other
source. But shouldn't we prefer a traits that contains exactly the minimum
amount of information we need to make the `FileReader` implem work ?
Proposition:
```
pub enum ChunkMode {
FromStart(u64),
FromEnd(u64),
}
pub trait ChunkReader {
type T: Read + Length;
fn get_read(&self, start: ChunkMode, length: usize) -> Result<Self::T>;
}
```
I can have the implem ready by the end of the day!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
