alamb commented on code in PR #3295:
URL: https://github.com/apache/arrow-rs/pull/3295#discussion_r1043423462
##########
arrow-string/src/length.rs:
##########
@@ -245,11 +245,10 @@ mod tests {
macro_rules! length_binary_helper {
($offset_ty: ty, $result_ty: ty, $kernel: ident, $value: expr,
$expected: expr) => {{
let array = GenericBinaryArray::<$offset_ty>::from($value);
- let result = $kernel(&array)?;
+ let result = $kernel(&array).unwrap();
Review Comment:
is this a drive by cleanup to use `unwrap` rather than `Error` in the tests?
##########
arrow/src/compute/kernels/comparison.rs:
##########
@@ -23,1227 +23,75 @@
//! [here](https://doc.rust-lang.org/stable/core/arch/) for more information.
//!
-use crate::array::*;
Review Comment:
What will be left in arrow-compute 🤔
##########
dev/release/README.md:
##########
@@ -258,6 +258,7 @@ Rust Arrow Crates:
(cd arrow-array && cargo publish)
(cd arrow-select && cargo publish)
(cd arrow-cast && cargo publish)
+(cd arrow-string && cargo publish)
Review Comment:
thank you for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
