tustvold commented on code in PR #3295:
URL: https://github.com/apache/arrow-rs/pull/3295#discussion_r1043428258


##########
arrow-string/src/length.rs:
##########
@@ -245,11 +245,10 @@ mod tests {
     macro_rules! length_binary_helper {
         ($offset_ty: ty, $result_ty: ty, $kernel: ident, $value: expr, 
$expected: expr) => {{
             let array = GenericBinaryArray::<$offset_ty>::from($value);
-            let result = $kernel(&array)?;
+            let result = $kernel(&array).unwrap();

Review Comment:
   Yes, it means you get an actual backtrace as opposed to some random error 
from somewhere :laughing: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to