mingmwang commented on code in PR #4562:
URL: https://github.com/apache/arrow-datafusion/pull/4562#discussion_r1045492576
##########
datafusion/core/src/physical_plan/joins/utils.rs:
##########
@@ -693,6 +700,222 @@ impl<T: 'static> OnceFut<T> {
}
}
+pub(crate) fn need_produce_result_in_final(join_type: JoinType) -> bool {
+ matches!(
+ join_type,
+ JoinType::Left | JoinType::LeftAnti | JoinType::LeftSemi |
JoinType::Full
+ )
+}
Review Comment:
I would suggest to add more comments to those methods. Originally they are
only used by HashJoin and they are private methods. Now they are used both by
HashJoin and NestedLoopJoin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
