[GitHub] [arrow] mapleFU commented on a diff in pull request #14351: ARROW-17904: [C++] Parquet Implement crc in reading and writing Page for DATA_PAGE (v1)

Mon, 12 Dec 2022 09:02:04 -0800 


mapleFU commented on code in PR #14351:
URL: https://github.com/apache/arrow/pull/14351#discussion_r1046105723


##########
cpp/src/parquet/column_reader.cc:
##########
@@ -400,6 +401,19 @@ std::shared_ptr<Page> SerializedPageReader::NextPage() {
       ParquetException::EofException(ss.str());
     }
 
+    const PageType::type page_type = LoadEnumSafe(&current_page_header_.type);
+
+    if (properties_.use_page_checksum_verification() &&
+        page_type == PageType::DATA_PAGE && current_page_header_.__isset.crc) {

Review Comment:
   > I don't understand what that would change? Whether you add it first to 
parquet-mr or to this implementation, you'll have the problem that the first 
implementation to get it will not be able to cross-validate.
   
   Well, I think that you're right, but let me just do it step by step. I'd 
like to keep this patch just write and check checksum in `DATA_PAGE_V1`.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to