mapleFU commented on code in PR #14351:
URL: https://github.com/apache/arrow/pull/14351#discussion_r1046625023


##########
cpp/src/parquet/file_deserialize_test.cc:
##########
@@ -315,6 +325,127 @@ TEST_F(TestPageSerde, LZONotSupported) {
   ASSERT_THROW(InitSerializedPageReader(data_size, Compression::LZO), 
ParquetException);
 }
 
+TEST_F(TestPageSerde, CrcEnabled) {

Review Comment:
   Do you mean `reader_test.cc`? I think they works in different layer. This 
test just test if our `Page` works, `reader_test` will check if it can read 
parquet-mr's file. I think we should keep it here
   
   If I missed something, please tell me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to