viirya commented on code in PR #3333:
URL: https://github.com/apache/arrow-rs/pull/3333#discussion_r1046238770
##########
parquet/src/bloom_filter/mod.rs:
##########
@@ -194,14 +238,14 @@ impl Sbbf {
/// Write the bitset in serialized form to the writer.
fn write_bitset<W: Write>(&self, mut writer: W) -> Result<(),
ParquetError> {
for block in &self.0 {
- for word in block {
- writer.write_all(&word.to_le_bytes()).map_err(|e| {
+ writer
+ .write_all(block.to_le_bytes().as_slice())
Review Comment:
Hmm, I think this doesn't write the bytes in same format as before. I guess
the reason to write each word in a block sequentially is to follow the spec?
Otherwise I have thought to write all words in a bulk like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
