viirya commented on code in PR #3333:
URL: https://github.com/apache/arrow-rs/pull/3333#discussion_r1046340702


##########
parquet/src/bloom_filter/mod.rs:
##########
@@ -194,14 +238,14 @@ impl Sbbf {
     /// Write the bitset in serialized form to the writer.
     fn write_bitset<W: Write>(&self, mut writer: W) -> Result<(), 
ParquetError> {
         for block in &self.0 {

Review Comment:
   If it is long slice for all blocks instead of `Vec<Block>`? Do you think it 
would be better?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to