fatemehp commented on code in PR #14603:
URL: https://github.com/apache/arrow/pull/14603#discussion_r1046384670
##########
cpp/src/parquet/metadata.h:
##########
@@ -182,6 +182,28 @@ class PARQUET_EXPORT ColumnChunkMetaData {
std::unique_ptr<ColumnChunkMetaDataImpl> impl_;
};
+/// \brief DataPageStats is a proxy around stats in format::PageHeader.
+class PARQUET_EXPORT DataPageStats {
+ public:
+ static std::unique_ptr<DataPageStats> Make(const void* page_header);
+
+ ~DataPageStats();
+
+ bool Equals(const DataPageStats& other) const;
+
+ int32_t num_values() const;
+ int32_t num_rows() const;
Review Comment:
> This is great, and valuable information that might not be obvious to a
parquet novice. Can you add this fact to the comments for this addition
somewhere?
I added this to the comments in the DataPageStats class. please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
