fatemehp commented on code in PR #14603:
URL: https://github.com/apache/arrow/pull/14603#discussion_r1049249236
##########
cpp/src/parquet/column_reader.h:
##########
@@ -115,11 +116,30 @@ class PARQUET_EXPORT PageReader {
bool always_compressed = false,
const CryptoContext* ctx = NULLPTR);
+ // If skip_page_callback_ is present (not null), NextPage() will call the
+ // callback function exactly once per page in the order the pages appear in
+ // the column. If the callback function returns true the page will be
+ // skipped. The callback will be called only if the page type is DATA_PAGE or
Review Comment:
I feel like since it is a filter, it should return true if it is filtering?
But I am not opposed to the other way around, especially if there is a
convention for how it should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
