westonpace commented on code in PR #14938:
URL: https://github.com/apache/arrow/pull/14938#discussion_r1047826532
##########
cpp/src/arrow/compute/kernels/vector_sort_benchmark.cc:
##########
@@ -301,5 +333,38 @@ BENCHMARK(TableSortIndicesInt64Wide)
})
->Unit(benchmark::TimeUnit::kNanosecond);
+//
+// Rank benchmark declarations
+//
+
+void ArrayRankSetArgs(benchmark::internal::Benchmark* bench) {
+ // 3 benchmark arguments: size, inverse null proportion, rank tiebreaker
+ bench->Unit(benchmark::kNanosecond);
Review Comment:
Mostly just a question but is there any particular reason to pin this? I
believe `kNanosecond` is the default and setting it this way prevents the user
from adjusting it on the command line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
