westonpace commented on code in PR #14938:
URL: https://github.com/apache/arrow/pull/14938#discussion_r1047832866
##########
cpp/src/arrow/compute/kernels/vector_sort_benchmark.cc:
##########
@@ -301,5 +333,38 @@ BENCHMARK(TableSortIndicesInt64Wide)
})
->Unit(benchmark::TimeUnit::kNanosecond);
+//
+// Rank benchmark declarations
+//
+
+void ArrayRankSetArgs(benchmark::internal::Benchmark* bench) {
+ // 3 benchmark arguments: size, inverse null proportion, rank tiebreaker
+ bench->Unit(benchmark::kNanosecond);
Review Comment:
Ah, I didn't see the setting in `RegrssionSetArgs`. I don't think it's too
big of a deal but agree it might be nice to let these drift and people can pin
it all if they care.
That being said, if we back this out, it would probably disturb continuous
benchmarking efforts so maybe not worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
