pitrou commented on code in PR #14938:
URL: https://github.com/apache/arrow/pull/14938#discussion_r1047827839
##########
cpp/src/arrow/compute/kernels/vector_sort_benchmark.cc:
##########
@@ -301,5 +333,38 @@ BENCHMARK(TableSortIndicesInt64Wide)
})
->Unit(benchmark::TimeUnit::kNanosecond);
+//
+// Rank benchmark declarations
+//
+
+void ArrayRankSetArgs(benchmark::internal::Benchmark* bench) {
+ // 3 benchmark arguments: size, inverse null proportion, rank tiebreaker
+ bench->Unit(benchmark::kNanosecond);
Review Comment:
Hmm... I blindly reproduced the existing options for SortIndices
benchmarks...
But now I see that it was probably because `RegressionSetArgs`, for whatever
reason, forces another unit.
Perhaps we should simply remove all these directives. As you point out, they
are actually user-hostile while not bringing any obvious value on their own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
