pitrou commented on code in PR #14938:
URL: https://github.com/apache/arrow/pull/14938#discussion_r1047833711
##########
cpp/src/arrow/compute/kernels/vector_sort_benchmark.cc:
##########
@@ -301,5 +333,38 @@ BENCHMARK(TableSortIndicesInt64Wide)
})
->Unit(benchmark::TimeUnit::kNanosecond);
+//
+// Rank benchmark declarations
+//
+
+void ArrayRankSetArgs(benchmark::internal::Benchmark* bench) {
+ // 3 benchmark arguments: size, inverse null proportion, rank tiebreaker
+ bench->Unit(benchmark::kNanosecond);
Review Comment:
I would hope that continuous benchmarking efforts are keyed on meaningful
metrics such as bytes/sec or items/sec, at least where they exist (and IIRC
they do).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
