wanweiqiangintel commented on code in PR #14674:
URL: https://github.com/apache/arrow/pull/14674#discussion_r1049622617
##########
cpp/src/arrow/util/bpacking.cc:
##########
@@ -166,14 +169,34 @@ struct Unpack32DynamicFunction {
}
};
+#if defined(ARROW_HAVE_AVX512_ICX)
+struct Unpack32DynamicFunctionICX {
+ using FunctionType = decltype(&unpack32_default);
+
+ static std::vector<std::pair<DispatchLevel, FunctionType>> implementations()
{
+ return {{DispatchLevel::NONE, unpack32_default},
+ {DispatchLevel::AVX512_ICX, unpack32_avx512_icx}};
+ }
+};
Review Comment:
Hi, @kou , yes, unpack32_avx512_icx() doesn't support num_bits > 16
currently, but the support of num_bits between 17 to 32 is in progress and
almost done. We need to do more tests about this and if it goes well, we will
upstream the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
