pitrou commented on code in PR #14674:
URL: https://github.com/apache/arrow/pull/14674#discussion_r1049623526
##########
cpp/src/arrow/util/bpacking.cc:
##########
@@ -166,14 +169,34 @@ struct Unpack32DynamicFunction {
}
};
+#if defined(ARROW_HAVE_AVX512_ICX)
+struct Unpack32DynamicFunctionICX {
+ using FunctionType = decltype(&unpack32_default);
+
+ static std::vector<std::pair<DispatchLevel, FunctionType>> implementations()
{
+ return {{DispatchLevel::NONE, unpack32_default},
+ {DispatchLevel::AVX512_ICX, unpack32_avx512_icx}};
+ }
+};
Review Comment:
Or `unpack32_avx512_icx` should simply fallback on `unpack32_avx512` for
`num_bits > 16`. We should not have two different dynamic dispatches for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
