jackwener commented on code in PR #4618:
URL: https://github.com/apache/arrow-datafusion/pull/4618#discussion_r1050355202
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -274,6 +284,77 @@ impl Optimizer {
debug!("Optimizer took {} ms", start_time.elapsed().as_millis());
Ok(new_plan)
}
+
+ fn optimize_node(
+ &self,
+ rule: &Arc<dyn OptimizerRule + Send + Sync>,
+ plan: &LogicalPlan,
+ optimizer_config: &mut OptimizerConfig,
+ ) -> Result<Option<LogicalPlan>> {
+ rule.try_optimize(plan, optimizer_config)
+ }
+
+ fn optimize_inputs(
+ &self,
+ rule: &Arc<dyn OptimizerRule + Send + Sync>,
+ plan: &LogicalPlan,
+ optimizer_config: &mut OptimizerConfig,
+ ) -> Result<Option<LogicalPlan>> {
+ let inputs = plan.inputs();
+ let result = inputs
+ .iter()
+ .map(|sub_plan| self.optimize_recursively(rule, sub_plan,
optimizer_config))
+ .collect::<Result<Vec<_>>>()?;
+ if result.is_empty() || result.iter().all(|o| o.is_none()) {
+ return Ok(None);
+ }
+
+ let new_inputs = result
+ .into_iter()
+ .enumerate()
+ .map(|(i, o)| match o {
+ Some(plan) => plan,
+ None => (*(inputs.get(i).unwrap())).clone(),
+ })
+ .collect::<Vec<_>>();
+
+ Ok(Some(plan.with_new_inputs(new_inputs.as_slice())?))
+ }
+
+ pub fn optimize_recursively(
Review Comment:
Sometime we need use it in UT😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
