tustvold commented on code in PR #4522:
URL: https://github.com/apache/arrow-datafusion/pull/4522#discussion_r1051033082
##########
datafusion/core/src/execution/memory_manager/mod.rs:
##########
@@ -17,419 +17,187 @@
//! Manages all available memory during query execution
-use crate::error::{DataFusionError, Result};
-use async_trait::async_trait;
-use hashbrown::HashSet;
-use log::{debug, warn};
-use parking_lot::{Condvar, Mutex};
-use std::fmt;
-use std::fmt::{Debug, Display, Formatter};
-use std::sync::atomic::{AtomicUsize, Ordering};
+use crate::error::Result;
use std::sync::Arc;
-use std::time::{Duration, Instant};
+mod pool;
pub mod proxy;
-static CONSUMER_ID: AtomicUsize = AtomicUsize::new(0);
-
-#[derive(Debug, Clone)]
-/// Configuration information for memory management
-pub enum MemoryManagerConfig {
Review Comment:
This was a bit of a perverse API imo, I'm looking into properly addressing
the `*Config` profileration in #4349 but I figured I might as well clean this
up whilst I was here.
If people want to reuse the same pool, they can just use the same `Arc<dyn
MemoryPool>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
