tustvold commented on code in PR #4522:
URL: https://github.com/apache/arrow-datafusion/pull/4522#discussion_r1051047941
##########
datafusion/core/src/execution/context.rs:
##########
@@ -2051,20 +2058,23 @@ mod tests {
let ctx1 = SessionContext::new();
// configure with same memory / disk manager
- let memory_manager = ctx1.runtime_env().memory_manager.clone();
+ let memory_pool = ctx1.runtime_env().memory_pool.clone();
+
+ let mut allocation = TrackedAllocation::new(&memory_pool,
"test".to_string());
+ allocation.grow(100);
+
let disk_manager = ctx1.runtime_env().disk_manager.clone();
let ctx2 =
SessionContext::with_config_rt(SessionConfig::new(),
ctx1.runtime_env());
- assert!(std::ptr::eq(
- Arc::as_ptr(&memory_manager),
- Arc::as_ptr(&ctx1.runtime_env().memory_manager)
- ));
- assert!(std::ptr::eq(
- Arc::as_ptr(&memory_manager),
- Arc::as_ptr(&ctx2.runtime_env().memory_manager)
- ));
+ assert_eq!(ctx1.runtime_env().memory_pool.allocated(), 100);
Review Comment:
This test had to be rewitten as pointer equality of fat pointers such as
`&dyn` is funky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
