waynexia commented on code in PR #4664:
URL: https://github.com/apache/arrow-datafusion/pull/4664#discussion_r1051619702
##########
datafusion/core/src/physical_plan/coalesce_batches.rs:
##########
@@ -197,14 +197,14 @@ impl CoalesceBatchesStream {
) -> Poll<Option<ArrowResult<RecordBatch>>> {
// Get a clone (uses same underlying atomic) as self gets borrowed
below
let cloned_time = self.baseline_metrics.elapsed_compute().clone();
- // records time on drop
- let _timer = cloned_time.timer();
if self.is_closed {
return Poll::Ready(None);
}
loop {
let input_batch = self.input.poll_next_unpin(cx);
+ // records time on drop
Review Comment:
good job 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
