rtpsw commented on code in PR #14682: URL: https://github.com/apache/arrow/pull/14682#discussion_r1052515351
########## python/pyarrow/_compute.pxd: ########## @@ -21,11 +21,11 @@ from pyarrow.lib cimport * from pyarrow.includes.common cimport * from pyarrow.includes.libarrow cimport * -cdef class ScalarUdfContext(_Weakrefable): +cdef class UdfContext(_Weakrefable): Review Comment: I don't mind undoing this name change. IIRC, @westonpace requested it, so he should have an opinion. As a side note, I wouldn't generally make an effort just to avoid a conflict with another pending PR. If a PR is a step in the right direction, then this is good enough, and any conflict will be resolved in remaining PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
