rtpsw commented on code in PR #14682:
URL: https://github.com/apache/arrow/pull/14682#discussion_r1052519650


##########
python/pyarrow/_compute.pxd:
##########
@@ -21,11 +21,11 @@ from pyarrow.lib cimport *
 from pyarrow.includes.common cimport *
 from pyarrow.includes.libarrow cimport *
 
-cdef class ScalarUdfContext(_Weakrefable):
+cdef class UdfContext(_Weakrefable):

Review Comment:
   > There is another issue, that I recall that I didn't name it like this. 
`CUdf` can get mixed up with `CudfContext` or related things. Need to come up 
with better naming too.
   
   I don't follow. At least in the recent commit, [`UdfContext` is a wrapper of 
`CUdfContext`](https://github.com/apache/arrow/blob/4236e37aaeef7fb92de4b241f3202f4e8a40463d/python/pyarrow/_compute.pyx#L2522-L2535).
 Where's the mix up?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to