pitrou commented on code in PR #15041:
URL: https://github.com/apache/arrow/pull/15041#discussion_r1055674843
##########
cpp/src/arrow/compute/kernels/vector_sort_benchmark.cc:
##########
@@ -106,6 +125,19 @@ static void ArraySortFuncBoolBenchmark(benchmark::State&
state, const Runner& ru
ArraySortFuncBenchmark(state, runner, values);
}
+template <typename Runner>
+static void ArraySortFuncStringBenchmark(benchmark::State& state, const
Runner& runner,
+ int64_t min_length, int64_t
max_length) {
+ RegressionArgs args(state);
+
+ const int64_t array_size = args.size / sizeof(int64_t);
Review Comment:
As for whether offsets should be taken into account, there's no obviously
right answer, but given that we don't count the null bitmap, I'd say we don't
_need_ to count the offsets buffer either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
